Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[schema] Add SAG table for static anycast gateway #540

Merged
merged 6 commits into from
Jan 25, 2024
Merged

[schema] Add SAG table for static anycast gateway #540

merged 6 commits into from
Jan 25, 2024

Conversation

superchild
Copy link
Contributor

Add SAG table definition for static anycast gateway.
Static anycast gateway HLD #837

Signed-off-by: Jimi Chen jimi_chen@edge-core.com

@superchild superchild mentioned this pull request Oct 20, 2021
Merged
@superchild superchild mentioned this pull request Oct 28, 2021
Open
hasan-brcm
hasan-brcm previously approved these changes Nov 5, 2021
View reviewed changes
preetham-singh
preetham-singh previously approved these changes Nov 13, 2021
View reviewed changes
@superchild
Copy link
Contributor Author

/AzurePipelines run Azure.sonic-swss-common

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 540 in repo Azure/sonic-swss-common

@superchild
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@superchild
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@superchild
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@superchild
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@superchild
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@superchild
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@superchild superchild dismissed stale reviews from preetham-singh and hasan-brcm via e8a7fcb May 4, 2022 01:01
@superchild
Copy link
Contributor Author

@preetham-singh @hasan-brcm
I fix some conflict with the master branch, could you help to review it again?
Thanks.

@zhangyanzhao
Copy link

Reviewers,
Can you please help to finish the review and merge this PR? I added the maintainers as well who by default will be the reviewer. Thanks.

@superchild
Copy link
Contributor Author

The easyCLA is signed, it should be ready to merge.

@superchild
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@superchild
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhangyanzhao
Copy link

/azpw run Azure.sonic-buildimage

@zhangyanzhao
Copy link

@superchild can you please sign the EasyCLA? That is required before the PR merge. Thanks.

@superchild
Copy link
Contributor Author

/easycla

@zhangyanzhao
Copy link

@qiluo-msft @marian-pritsak can you please help to merge this PR? It has been approved. Thanks.

@qiluo-msft qiluo-msft merged commit e4db436 into sonic-net:master Jan 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

@venkatmahalingam venkatmahalingam venkatmahalingam approved these changes

@Junchao-Mellanox Junchao-Mellanox Junchao-Mellanox approved these changes

@preetham-singh preetham-singh preetham-singh left review comments

@hasan-brcm hasan-brcm hasan-brcm left review comments

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

@liuh-80 liuh-80 Awaiting requested review from liuh-80

@svshah-intel svshah-intel Awaiting requested review from svshah-intel

@marian-pritsak marian-pritsak Awaiting requested review from marian-pritsak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@superchild @mssonicbld @zhangyanzhao @prsunny @venkatmahalingam @preetham-singh @hasan-brcm @Junchao-Mellanox @qiluo-msft